Skip to content

Add host resolution support to tsh scp#48465

Merged
rosstimothy merged 1 commit intomasterfrom
tross/scp_proxy_templates
Nov 19, 2024
Merged

Add host resolution support to tsh scp#48465
rosstimothy merged 1 commit intomasterfrom
tross/scp_proxy_templates

Conversation

@rosstimothy
Copy link
Copy Markdown
Contributor

@rosstimothy rosstimothy commented Nov 5, 2024

Extends tsh scp functionality to honor any defined proxy templates when resolving the teleport host.

Closes #45465

Changelog: Update tsh scp to respect proxy templates when resolving the remote host.

@aws-amplify-us-west-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48465.d3pp5qlev8mo18.amplifyapp.com

@rosstimothy rosstimothy force-pushed the tross/scp_proxy_templates branch 2 times, most recently from 0670342 to f80d28c Compare November 6, 2024 20:58
@rosstimothy rosstimothy marked this pull request as ready for review November 6, 2024 21:21
@github-actions github-actions Bot added size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Nov 6, 2024
Comment thread lib/client/api.go Outdated
Comment thread lib/client/api.go Outdated
Comment thread tool/tsh/common/tsh.go Outdated
@rosstimothy rosstimothy requested a review from bl-nero November 12, 2024 14:18
@rosstimothy
Copy link
Copy Markdown
Contributor Author

Friendly ping @bl-nero @fspmarshall

@rosstimothy
Copy link
Copy Markdown
Contributor Author

PTAL @bl-nero @fspmarshall

@rosstimothy rosstimothy force-pushed the tross/scp_proxy_templates branch from 78b98b5 to 73b7107 Compare November 19, 2024 17:46
Extends tsh scp functionality to honor any defined proxy templates
when resolving the remote host.

Closes #45465
@rosstimothy rosstimothy force-pushed the tross/scp_proxy_templates branch from 73b7107 to 55d1dd4 Compare November 19, 2024 18:07
@rosstimothy rosstimothy added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit e92dd31 Nov 19, 2024
@rosstimothy rosstimothy deleted the tross/scp_proxy_templates branch November 19, 2024 18:43
@public-teleport-github-review-bot
Copy link
Copy Markdown

@rosstimothy See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Create PR
branch/v17 Create PR

rosstimothy added a commit that referenced this pull request Nov 19, 2024
Extends tsh scp functionality to honor any defined proxy templates
when resolving the remote host.

Closes #45465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add host resolution support to tsh scp

3 participants