fix: prevent tctl edit overwriting static file config#48329
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
approved these changes
Nov 2, 2024
marcoandredinis
approved these changes
Nov 4, 2024
public-teleport-github-review-bot
Bot
removed request for
doggydogworld and
ravicious
nklaassen
added
no-changelog
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@nklaassen See the table below for backport results.
|
This was referenced Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tctl create -fprevents overwriting thecluster_auth_preference,cluster_networking_config, orsession_recording_configif their configuration is coming from a static config file. Any dynamic edits made to these resources would be overwritten the next time the auth server restarts, so a user trying to edit them usingtctlis usually making a mistake.tctl createprevents this mistake unless the user explicitly passes--confirmwhich might be useful in some break-glass scenarios.But unfortunately
tctl editdoes nothing to prevent edits to these resources and I have confused myself many times when my config later gets overwritten after a successfultctl edit. This PR updatestctl editto do the same check and require the--confirmflag to edit any resources configured statically.changelog: Added a warning to
tctl editabout dynamic edits to statically configured resources