Skip to content

enforce conditional updates on AutoUpdate* + rename typos#48240

Merged
hugoShaka merged 2 commits intomasterfrom
hugo/autoupdate-service-conditional-update
Nov 4, 2024
Merged

enforce conditional updates on AutoUpdate* + rename typos#48240
hugoShaka merged 2 commits intomasterfrom
hugo/autoupdate-service-conditional-update

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka commented Oct 31, 2024

Fixes:

  • the autoupdate service to do conditional updates (check if the revisionID matches before writing to the backend)
  • a few variables I did not rename when copy-pasting code

@aws-amplify-us-west-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48240.d3pp5qlev8mo18.amplifyapp.com

@hugoShaka hugoShaka added the no-changelog Indicates that a PR does not require a changelog entry label Oct 31, 2024
@espadolini
Copy link
Copy Markdown
Contributor

Those RPCs and methods only exist in master and branch/v17, right? Not in any release.

@hugoShaka hugoShaka force-pushed the hugo/autoupdate-service-conditional-update branch from 21b0779 to b4e12e5 Compare November 4, 2024 14:59
@hugoShaka hugoShaka added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@hugoShaka hugoShaka added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@hugoShaka hugoShaka added this pull request to the merge queue Nov 4, 2024
Merged via the queue into master with commit e85c7c2 Nov 4, 2024
@hugoShaka hugoShaka deleted the hugo/autoupdate-service-conditional-update branch November 4, 2024 18:54
@public-teleport-github-review-bot
Copy link
Copy Markdown

@hugoShaka See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 bug merge-for-v17 no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants