Apply request.kubernetes_resources allow/deny settings when querying for kube resources#48196
Merged
Apply request.kubernetes_resources allow/deny settings when querying for kube resources#48196
Conversation
kimlisa
force-pushed
the
lisa/add-request-type-check
branch
from
b243c2f to
70c6e05
Compare
kimlisa
force-pushed
the
lisa/add-request-mode-role-option
branch
from
b98a970 to
51998b5
Compare
kimlisa
force-pushed
the
lisa/add-request-type-check
branch
from
70c6e05 to
d587dea
Compare
nklaassen
reviewed
Oct 31, 2024
kimlisa
force-pushed
the
lisa/add-request-mode-role-option
branch
2 times, most recently
from
d69b2f5 to
f8dc68e
Compare
kimlisa
force-pushed
the
lisa/add-request-type-check
branch
from
d587dea to
c97e134
Compare
nklaassen
reviewed
Nov 1, 2024
kimlisa
force-pushed
the
lisa/add-request-type-check
branch
from
565c6e2 to
a4fe48c
Compare
nklaassen
approved these changes
Nov 1, 2024
tigrato
approved these changes
Nov 4, 2024
kimlisa
added
the
no-changelog
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
kimlisa
added a commit
that referenced
this pull request
Nov 4, 2024
…for kube resources (#48196) * Apply request.kubernetes_resources allow/deny when querying for kube resources * Address CR
kimlisa
added a commit
that referenced
this pull request
Nov 5, 2024
…for kube resources (#48196) * Apply request.kubernetes_resources allow/deny when querying for kube resources * Address CR
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
#48387) * Add a new `role.allow.request` field called `kubernetes_resources` (#47173) * Add a new role.allow.request field called kubernetes_resources * Fix lint: update terraform docs * Apply request.kubernetes_resources allow/deny settings when querying for kube resources (#48196) * Apply request.kubernetes_resources allow/deny when querying for kube resources * Address CR * Replace unsupported library funcs * Add missing role conditions getter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #46742
addresses review comment on #47173 (review)
Now, when user query for kube resources, when going through search as roles, ensure that
request.kubernetes_resourcesallow and deny settings are respected for the requested kube resource kind. If no roles matched, the query request will return aaccess deniederror