Skip to content

Add dynamic Windows desktops to terraform provider#48160

Merged
probakowski merged 8 commits intomasterfrom
probakowski/registration-terraform
Nov 15, 2024
Merged

Add dynamic Windows desktops to terraform provider#48160
probakowski merged 8 commits intomasterfrom
probakowski/registration-terraform

Conversation

@probakowski
Copy link
Copy Markdown
Contributor

@probakowski probakowski commented Oct 30, 2024 •
edited
Loading

Related to #37103

changelog: Added dynamic Windows desktops to terraform provider

@probakowski probakowski requested a review from hugoShaka October 30, 2024 18:41
@aws-amplify-us-west-2
Copy link
Copy Markdown

aws-amplify-us-west-2 Bot commented Oct 30, 2024

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48160.d3pp5qlev8mo18.amplifyapp.com

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 30, 2024

🤖 Vercel preview here: https://docs-4h0mzm8u4-goteleport.vercel.app/docs/ver/preview

@probakowski probakowski force-pushed the probakowski/registration-terraform branch from d751ff8 to 1aa2e54 Compare October 30, 2024 19:01
@probakowski probakowski force-pushed the probakowski/registration-terraform branch from 1aa2e54 to d6b6c9d Compare October 30, 2024 19:02
@probakowski probakowski requested a review from zmb3 October 30, 2024 19:04
@probakowski probakowski marked this pull request as ready for review October 30, 2024 19:04
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Oct 30, 2024

@probakowski - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes.

@probakowski probakowski changed the title Add Windows desktops to terraform provider Add dynamic Windows desktops to terraform provider Oct 30, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 30, 2024

🤖 Vercel preview here: https://docs-f0xuqhaeg-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 30, 2024

🤖 Vercel preview here: https://docs-g0vo0sb1u-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 30, 2024

🤖 Vercel preview here: https://docs-hekpe9wft-goteleport.vercel.app/docs/ver/preview

hugoShaka
hugoShaka approved these changes Oct 31, 2024
View reviewed changes
Comment thread integrations/terraform/examples/resources/teleport_dynamic_windows_desktop/resource.tf Outdated
Comment on lines +1 to +3
# Teleport Database

resource "teleport_dynamic_windows_desktop" "example" {
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Teleport Database
resource "teleport_dynamic_windows_desktop" "example" {
resource "teleport_dynamic_windows_desktop" "example" {

Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: you'll need to re-render the docs after this change.

@hugoShaka
Copy link
Copy Markdown
Contributor

hugoShaka commented Oct 31, 2024 •
edited
Loading

Should we backport the PR? To which version(s)?

marcoandredinis
marcoandredinis reviewed Nov 1, 2024
View reviewed changes
Comment thread lib/services/presets.go
@hugoShaka hugoShaka force-pushed the probakowski/registration-terraform branch from bc76f9c to 89dd04b Compare November 15, 2024 15:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 15, 2024

🤖 Vercel preview here: https://docs-g8tnacd25-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 15, 2024

🤖 Vercel preview here: https://docs-67lqf645u-goteleport.vercel.app/docs/ver/preview

@probakowski probakowski added this pull request to the merge queue Nov 15, 2024
Merged via the queue into master with commit 94dc1a9 Nov 15, 2024
@probakowski probakowski deleted the probakowski/registration-terraform branch November 15, 2024 16:44
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Nov 15, 2024

@probakowski See the table below for backport results.

Branch Result
branch/v17 Create PR

This was referenced Nov 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoandredinis marcoandredinis marcoandredinis left review comments

@hugoShaka hugoShaka hugoShaka approved these changes

@r0mant r0mant r0mant approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees

No one assigned

Labels

backport/branch/v17 documentation size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@probakowski @hugoShaka @r0mant @marcoandredinis @zmb3