Merged
Conversation
Closed
Joerger
added
the
no-changelog
Joerger
force-pushed
the
joerger/sso-mfa-connect-base
branch
from
a49742b to
72b86b5
Compare
Joerger
force-pushed
the
joerger/sso-mfa-connect
branch
from
f5c8854 to
a9a4fec
Compare
gzdunek
reviewed
Oct 31, 2024
Joerger
force-pushed
the
joerger/sso-mfa-connect
branch
from
8cab8f0 to
58e7152
Compare
ravicious
reviewed
Nov 4, 2024
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
I submitted some minor issues, but it looks good overall.
Joerger
force-pushed
the
joerger/sso-mfa-connect-base
branch
from
9a60a6b to
f19809c
Compare
Joerger
force-pushed
the
joerger/sso-mfa-connect
branch
from
58e7152 to
9dde5dd
Compare
gzdunek
reviewed
Nov 5, 2024
ravicious
approved these changes
Nov 5, 2024
gzdunek
approved these changes
Nov 6, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from avatus
Joerger
force-pushed
the
joerger/sso-mfa-connect
branch
from
88e6c90 to
b77dba2
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the implementation of #44699
Handle SSO MFA in Teleport Connect. This PR adds a new option for SSO MFA (when applicable) in the existing MFA prompt dialog:
Clicking the option opens the SSO redirect URL and shows a familiar "follow steps in browser window" message:
Completing the SSO flow in the browser closes the dialog and successfully continues to the session as normal.
Depends on #46982 and #48035