Skip to content

[kube] fixes duplicated session recordings in root and leaf clusters#47910

Merged
tigrato merged 1 commit intomasterfrom
tigrato/fix-kube-duplicated-recordings
Nov 11, 2024
Merged

[kube] fixes duplicated session recordings in root and leaf clusters#47910
tigrato merged 1 commit intomasterfrom
tigrato/fix-kube-duplicated-recordings

Conversation

@tigrato
Copy link
Copy Markdown
Contributor

@tigrato tigrato commented Oct 24, 2024

This PR addresses a bug in Kubernetes session recordings where both the root proxy and the leaf cluster's Kubernetes services were recording the same session, resulting in the session being available in both clusters.

This behavior was inconsistent with other protocols, where recordings of leaf resources are only accessible in leaf clusters. To maintain consistency, this PR removes session recordings on the root clusters.

Changelog: Fixes bug in Kubernetes session recordings where both root and leaf cluster recorded the same Kubernetes session. Recordings of leaf resources are only available in leaf clusters.

@aws-amplify-us-west-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47910.d3pp5qlev8mo18.amplifyapp.com

@aws-amplify-us-west-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47910.d212ksyjt6y4yg.amplifyapp.com

@hugoShaka
Copy link
Copy Markdown
Contributor

I know this wasn't intentional but this can be considered as a feature by some users. I would consider this change breaking and not backport it to older versions.

@rosstimothy
Copy link
Copy Markdown
Contributor

I know this wasn't intentional but this can be considered as a feature by some users. I would consider this change breaking and not backport it to older versions.

IMO this is a bug and we should fix it to be consistent with the recording behavior observed for other protocols. @russjones what do you think?

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from camscale November 8, 2024 15:27
@tigrato tigrato enabled auto-merge November 8, 2024 15:28
@tigrato tigrato force-pushed the tigrato/fix-kube-duplicated-recordings branch from 81fa5b0 to 06d86e1 Compare November 8, 2024 16:13
This PR addresses a bug in Kubernetes session recordings where both the root proxy and the leaf cluster's Kubernetes services were recording the same session, resulting in the session being available in both clusters.

This behavior was inconsistent with other protocols, where recordings of leaf resources are only accessible in leaf clusters. To maintain consistency, this PR removes session recordings on the root clusters.

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@tigrato tigrato force-pushed the tigrato/fix-kube-duplicated-recordings branch from 06d86e1 to 6b69d47 Compare November 11, 2024 09:56
@tigrato tigrato added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit 5711ee9 Nov 11, 2024
@tigrato tigrato deleted the tigrato/fix-kube-duplicated-recordings branch November 11, 2024 10:32
@public-teleport-github-review-bot
Copy link
Copy Markdown

@tigrato See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed
branch/v16 Failed

@public-teleport-github-review-bot
Copy link
Copy Markdown

@tigrato See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed
branch/v16 Failed
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants