Adds caching support for Identity Center resources#47880
Merged
Conversation
tcsc
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
tcsc
force-pushed
the
tcsc/ic-resource-caching
branch
2 times, most recently
from
a75d6e0 to
0f39f70
Compare
smallinsky
reviewed
Oct 24, 2024
smallinsky
approved these changes
Oct 24, 2024
greedy52
approved these changes
Oct 24, 2024
r0mant
approved these changes
Oct 24, 2024
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
Seems a lot of this is just boilerplate so I've only done a cursory scan.
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
tcsc
changed the title
Adds support for caching (and watching) some IdentityCenter resource types. Specifically: - identitycenterv1.Account - identitycenterv1.AccountAsssignment - identitycenterv1.PrincipalAssignment Also breaks the cache's `genericcollection` out into its own file as an attempt to reduce clutter in the main collections source file.
tcsc
force-pushed
the
tcsc/ic-resource-caching
branch
from
e271eba to
5d3e11f
Compare
tcsc
added a commit
that referenced
this pull request
Oct 29, 2024
* Adds caching support for Identity Center resources Adds support for caching (and watching) some IdentityCenter resource types. Specifically: - identitycenterv1.Account - identitycenterv1.AccountAsssignment - identitycenterv1.PrincipalAssignment Also breaks the cache's `genericcollection` out into its own file as an attempt to reduce clutter in the main collections source file. * Update identitycenter_events.go * Update identitycenter_events.go * Speed up tests
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
* Adds caching support for Identity Center resources Adds support for caching (and watching) some IdentityCenter resource types. Specifically: - identitycenterv1.Account - identitycenterv1.AccountAsssignment - identitycenterv1.PrincipalAssignment Also breaks the cache's `genericcollection` out into its own file as an attempt to reduce clutter in the main collections source file. * Update identitycenter_events.go * Update identitycenter_events.go * Speed up tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.