Refactor CLI prompt and config logic#47874
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Joerger
added
the
no-changelog
Closed
codingllama
reviewed
Oct 24, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Many thanks for the standalone refactor, Brian! Looking good.
codingllama
approved these changes
Oct 24, 2024
* Move CLI prompt configuration to CLIPrompt * Factor out dual prompt in CLI prompt logic.
Joerger
force-pushed
the
joerger/cli-prompt-refactor
branch
from
a85d056 to
c8d3827
Compare
bernardjkim
approved these changes
Oct 24, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from probakowski
Joerger
added a commit
that referenced
this pull request
Oct 24, 2024
* Refactor CLI prompt and config logic. * Move CLI prompt configuration to CLIPrompt * Factor out dual prompt in CLI prompt logic. * Make cli config a field rather than embedded; Add NewCLIPromptV2.
Joerger
added a commit
that referenced
this pull request
Oct 24, 2024
* Refactor CLI prompt and config logic. * Move CLI prompt configuration to CLIPrompt * Factor out dual prompt in CLI prompt logic. * Make cli config a field rather than embedded; Add NewCLIPromptV2.
This was referenced Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor CLI prompt and config logic in preparation for some UX changes coming with SSO MFA. These changes will make sense in the context of the SSO MFA changes to follow. This PR is separate in order to backport this refactored logic and simplify future backports when needed.