Remove expirations for managed users#47774
Conversation
| return users, -1, nil | ||
| } | ||
|
|
||
| func UserHasExpirations(username string) (bool bool, exitCode int, err error) { |
There was a problem hiding this comment.
It looks like this is following the pattern of other functions in this file of returning an exit code when shelling out to an external binary. However, I wonder if that makes sense from an API perspective. These functions don't expose to users which binaries were being invoked, and are instead meant to abstract away the fact that some other binary is being used. By returning the exit code, we leak that information to callers, without giving them much insight into what the values of the exit codes might mean.
There was a problem hiding this comment.
Yeah I agree that the exit codes aren't especially useful for any of these functions. I'll submit a separate PR updating utils/host/hostusers.go that removes exit codes from the return types
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
eriktate
force-pushed
the
eriktate/host-user-password-expiration
branch
from
8f1db91 to
47df5bb
Compare
|
@Joerger @strideynet friendly bump 😄 |
|
@Joerger @strideynet Sending another nudge |
public-teleport-github-review-bot
Bot
removed the request for review
from Joerger
…s or password locks for managed teleport users
eriktate
force-pushed
the
eriktate/host-user-password-expiration
branch
from
47df5bb to
d435e8a
Compare
3 participants
This PR attempts to remove any password or account expirations from host users managed by Teleport. This will happen during new user creation and when resolving updates against existing managed users. It will not remove expirations from unmanaged users (test coverage for this coming soon). These changes are meant to prevent password expiration warnings, and eventual account disabling, caused by local password policies on some hosts.
changelog: Updated host user creation to prevent local password expiration policies from affecting Teleport managed users.