Skip to content

Add metric to expose cluster role count#47731

Merged
rosstimothy merged 3 commits intomasterfrom
tross/role_count
Oct 22, 2024
Merged

Add metric to expose cluster role count#47731
rosstimothy merged 3 commits intomasterfrom
tross/role_count

Conversation

@rosstimothy
Copy link
Copy Markdown
Contributor

@rosstimothy rosstimothy commented Oct 19, 2024

A new teleport_roles_total is added to count the number of roles in the cluster. The metric is intentionally updated infrequently to avoid putting any additional strain on the backend. Additionally, the reads performed when calculating the metric are rate limited to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single multi-interval instead of a ticker per operation. To prevent the sub-intervals from impacting each other all operations are moved to their own goroutine once their ticker fires.

changelog: Added a new teleport_roles_total metric that exposes the number of roles which exist in a cluster

@rosstimothy rosstimothy force-pushed the tross/role_count branch 3 times, most recently from 817e1a8 to 30af33d Compare October 19, 2024 18:26
Comment thread lib/auth/auth.go
Comment thread lib/auth/auth.go Outdated
Comment thread lib/auth/auth.go Outdated
A new `teleport_roles_total` is added to count the number of roles
in the cluster. The metric is intentionally updated infrequently
to avoid putting any additional strain on the backend. Additionally,
the reads performed when calculating the metric are rate limited
to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single
multi-interval instead of a ticker per operation. To prevent the
sub-intervals from impacting each other all operations are moved
to their own goroutine once their ticker fires.
@rosstimothy rosstimothy marked this pull request as ready for review October 21, 2024 18:32
rosstimothy added a commit that referenced this pull request Oct 21, 2024
Add the new metric introduced in #47731
to the reference page. Also performed some minor formatting on the
table, and alphabetized some out of order metrics.
@rosstimothy rosstimothy added this pull request to the merge queue Oct 22, 2024
Merged via the queue into master with commit b8f2853 Oct 22, 2024
@rosstimothy rosstimothy deleted the tross/role_count branch October 22, 2024 13:52
@public-teleport-github-review-bot
Copy link
Copy Markdown

@rosstimothy See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed
branch/v16 Failed

github-merge-queue Bot pushed a commit that referenced this pull request Oct 22, 2024
Add the new metric introduced in #47731
to the reference page. Also performed some minor formatting on the
table, and alphabetized some out of order metrics.
github-actions Bot pushed a commit that referenced this pull request Oct 22, 2024
Add the new metric introduced in #47731
to the reference page. Also performed some minor formatting on the
table, and alphabetized some out of order metrics.
github-actions Bot pushed a commit that referenced this pull request Oct 22, 2024
Add the new metric introduced in #47731
to the reference page. Also performed some minor formatting on the
table, and alphabetized some out of order metrics.
rosstimothy added a commit that referenced this pull request Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles
in the cluster. The metric is intentionally updated infrequently
to avoid putting any additional strain on the backend. Additionally,
the reads performed when calculating the metric are rate limited
to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single
multi-interval instead of a ticker per operation. To prevent the
sub-intervals from impacting each other all operations are moved
to their own goroutine once their ticker fires.

* fix: specify a smallish page size
rosstimothy added a commit that referenced this pull request Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles
in the cluster. The metric is intentionally updated infrequently
to avoid putting any additional strain on the backend. Additionally,
the reads performed when calculating the metric are rate limited
to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single
multi-interval instead of a ticker per operation. To prevent the
sub-intervals from impacting each other all operations are moved
to their own goroutine once their ticker fires.
rosstimothy added a commit that referenced this pull request Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles
in the cluster. The metric is intentionally updated infrequently
to avoid putting any additional strain on the backend. Additionally,
the reads performed when calculating the metric are rate limited
to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single
multi-interval instead of a ticker per operation. To prevent the
sub-intervals from impacting each other all operations are moved
to their own goroutine once their ticker fires.
rosstimothy added a commit that referenced this pull request Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles
in the cluster. The metric is intentionally updated infrequently
to avoid putting any additional strain on the backend. Additionally,
the reads performed when calculating the metric are rate limited
to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single
multi-interval instead of a ticker per operation. To prevent the
sub-intervals from impacting each other all operations are moved
to their own goroutine once their ticker fires.
rosstimothy added a commit that referenced this pull request Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles
in the cluster. The metric is intentionally updated infrequently
to avoid putting any additional strain on the backend. Additionally,
the reads performed when calculating the metric are rate limited
to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single
multi-interval instead of a ticker per operation. To prevent the
sub-intervals from impacting each other all operations are moved
to their own goroutine once their ticker fires.
rosstimothy added a commit that referenced this pull request Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles
in the cluster. The metric is intentionally updated infrequently
to avoid putting any additional strain on the backend. Additionally,
the reads performed when calculating the metric are rate limited
to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single
multi-interval instead of a ticker per operation. To prevent the
sub-intervals from impacting each other all operations are moved
to their own goroutine once their ticker fires.
github-merge-queue Bot pushed a commit that referenced this pull request Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles
in the cluster. The metric is intentionally updated infrequently
to avoid putting any additional strain on the backend. Additionally,
the reads performed when calculating the metric are rate limited
to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single
multi-interval instead of a ticker per operation. To prevent the
sub-intervals from impacting each other all operations are moved
to their own goroutine once their ticker fires.
github-merge-queue Bot pushed a commit that referenced this pull request Oct 22, 2024
A new `teleport_roles_total` is added to count the number of roles
in the cluster. The metric is intentionally updated infrequently
to avoid putting any additional strain on the backend. Additionally,
the reads performed when calculating the metric are rate limited
to prevent any bursts in reads when the metric timer does fire.

The auth periodic tickers have also been consolidated into a single
multi-interval instead of a ticker per operation. To prevent the
sub-intervals from impacting each other all operations are moved
to their own goroutine once their ticker fires.
rosstimothy added a commit that referenced this pull request Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval,
however the upgrade window check called from the periodic launched
it's own periodic, leading to a runaway number of upgrade window
checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot pushed a commit that referenced this pull request Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval,
however the upgrade window check called from the periodic launched
it's own periodic, leading to a runaway number of upgrade window
checks. This removes the extra periodic to reduce load upstream.
github-actions Bot pushed a commit that referenced this pull request Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval,
however the upgrade window check called from the periodic launched
it's own periodic, leading to a runaway number of upgrade window
checks. This removes the extra periodic to reduce load upstream.
github-actions Bot pushed a commit that referenced this pull request Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval,
however the upgrade window check called from the periodic launched
it's own periodic, leading to a runaway number of upgrade window
checks. This removes the extra periodic to reduce load upstream.
github-actions Bot pushed a commit that referenced this pull request Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval,
however the upgrade window check called from the periodic launched
it's own periodic, leading to a runaway number of upgrade window
checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot pushed a commit that referenced this pull request Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval,
however the upgrade window check called from the periodic launched
it's own periodic, leading to a runaway number of upgrade window
checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot pushed a commit that referenced this pull request Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval,
however the upgrade window check called from the periodic launched
it's own periodic, leading to a runaway number of upgrade window
checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot pushed a commit that referenced this pull request Oct 31, 2024
#47731 consolidated the auth periodics to use a multi.Interval,
however the upgrade window check called from the periodic launched
it's own periodic, leading to a runaway number of upgrade window
checks. This removes the extra periodic to reduce load upstream.
github-merge-queue Bot pushed a commit that referenced this pull request Nov 1, 2024
Add the new metric introduced in #47731
to the reference page. Also performed some minor formatting on the
table, and alphabetized some out of order metrics.
github-merge-queue Bot pushed a commit that referenced this pull request Nov 13, 2024
Add the new metric introduced in #47731
to the reference page. Also performed some minor formatting on the
table, and alphabetized some out of order metrics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants