Skip to content

Fix TestAutoEnroll_disabledByEnv flakiness#47723

Merged
codingllama merged 2 commits intomasterfrom
codingllama/autoenroll-flake
Oct 18, 2024
Merged

Fix TestAutoEnroll_disabledByEnv flakiness#47723
codingllama merged 2 commits intomasterfrom
codingllama/autoenroll-flake

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

@codingllama codingllama commented Oct 18, 2024

Fix flakiness introduced by #47679.

Comment thread lib/devicetrust/enroll/auto_enroll_test.go Outdated
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
@codingllama codingllama added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 335cae0 Oct 18, 2024
@codingllama codingllama deleted the codingllama/autoenroll-flake branch October 18, 2024 19:18
@public-teleport-github-review-bot
Copy link
Copy Markdown

@codingllama See the table below for backport results.

Branch Result
branch/v16 Failed

codingllama added a commit that referenced this pull request Oct 18, 2024
* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

---------

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
codingllama added a commit that referenced this pull request Oct 18, 2024
* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

---------

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
codingllama added a commit that referenced this pull request Oct 18, 2024
* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

---------

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue Bot pushed a commit that referenced this pull request Oct 18, 2024
* feat: Disable auto-enroll via environment variable

* Fix TestAutoEnroll_disabledByEnv flakiness (#47723)

* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

---------

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

---------

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue Bot pushed a commit that referenced this pull request Oct 18, 2024
* feat: Disable auto-enroll via environment variable

* Fix TestAutoEnroll_disabledByEnv flakiness (#47723)

* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

---------

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

---------

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue Bot pushed a commit that referenced this pull request Oct 18, 2024
* feat: Disable auto-enroll via environment variable

* Fix TestAutoEnroll_disabledByEnv flakiness (#47723)

* Fix TestAutoEnroll_disabledByEnv flakiness

* Use t.Setenv

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

---------

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>

---------

Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants