feat: SSO MFA - SSO MFA challenge creation and verification#47684
Merged
feat: SSO MFA - SSO MFA challenge creation and verification#47684
Conversation
Joerger
commented
Oct 17, 2024
Comment on lines
+2166
to
+2169
| // TODO(Joerger): Extend SSO MFA support for moderated sessions. | ||
| var ssoClientRedirectURL string |
Contributor
Author
There was a problem hiding this comment.
This will be implemented in a follow up PR when I can get to it, but it's not a priority over per-session MFA and other MFA features.
Joerger
added
the
no-changelog
Closed
Joerger
force-pushed
the
joerger/sso-mfa-challenge
branch
from
ef1d5f1 to
47c0975
Compare
Joerger
force-pushed
the
joerger/sso-mfa-challenge
branch
from
47c0975 to
ce9dea5
Compare
Contributor
|
Is this testable? Or just adds code that will be used in later PRs? |
nklaassen
approved these changes
Oct 22, 2024
Contributor
Author
It's not quite functional, the next PR makes use of the challenges/responses. It's based off this PR so you could just test that. edit: that PR only works with |
Joerger
force-pushed
the
joerger/sso-mfa-challenge
branch
from
ce9dea5 to
60b4fe2
Compare
marcoandredinis
approved these changes
Oct 24, 2024
… Require SSO MFA for device registration when available.
Joerger
force-pushed
the
joerger/sso-mfa-challenge
branch
from
99d7ee1 to
0c3ac99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the implementation of SSO MFA
Depends on https://github.com/gravitational/teleport.e/pull/5176