Skip to content

Fix Machine ID GitHub Discover flow#47673

Merged
strideynet merged 6 commits intomasterfrom
strideynet/fix-bot-onboarding-github
Oct 18, 2024
Merged

Fix Machine ID GitHub Discover flow#47673
strideynet merged 6 commits intomasterfrom
strideynet/fix-bot-onboarding-github

Conversation

@strideynet
Copy link
Copy Markdown
Contributor

Fixed three problems with this:

  1. Made the linux user a required field - without this you can't actually SSH into anything
  2. Removed the unneeded Kubernetes fields from the role.
  3. Fixed the indentation in the YAML for the node_labels. A single set of label would be dropped due to wrong identing, and more than one would cause the flow to crash.

changelog: Fixed the Machine ID and GitHub Actions wizard.

Copy link
Copy Markdown
Contributor

@mcbattirola mcbattirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

Comment thread web/packages/teleport/src/Bots/Add/GitHubActions/ConfigureBot.tsx Outdated
@strideynet strideynet added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@strideynet strideynet added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 913781b Oct 18, 2024
@strideynet strideynet deleted the strideynet/fix-bot-onboarding-github branch October 18, 2024 15:25
@public-teleport-github-review-bot
Copy link
Copy Markdown

@strideynet See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants