[buddy] fix: use proxy from env for compatible integrations#47663
Merged
[buddy] fix: use proxy from env for compatible integrations#47663
Conversation
Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
changed the title
marcoandredinis
approved these changes
Oct 17, 2024
hugoShaka
approved these changes
Oct 17, 2024
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
I think we should be careful with backporting as this is potentially disruptive. We were happily ignoring HTTP_PROXY until now, but we'll start to honour them.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
I don't think this will be a major issue because most of the cases, proxies are used to bypass external connectivity limitations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47604
Changelog: Respect
HTTP_PROXYenvironment variables for Access Request integrations.