Add support to Firestore backends for custom databases#47540
Merged
rosstimothy merged 1 commit intomasterfrom Oct 15, 2024
Merged
Add support to Firestore backends for custom databases#47540rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
Contributor
|
🤖 Vercel preview here: https://docs-hn42zvvvy-goteleport.vercel.app/docs/ver/preview |
rosstimothy
force-pushed
the
tross/firestore_database
branch
from
1b11bb5 to
f01841b
Compare
Contributor
|
🤖 Vercel preview here: https://docs-kp4sn5vmc-goteleport.vercel.app/docs/ver/preview |
rosstimothy
changed the title
github-actions
Bot
added
audit-log
github-actions
Bot
requested review from
espadolini,
fspmarshall,
kiosion,
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
espadolini
requested changes
Oct 14, 2024
Contributor
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
The admin client is used to create indices, but the "parent" parameter in the ensureIndexes methods on firestoreevents.Log and firestorebk.Backend is "projects/" + l.ProjectID + "/databases/(default)/collectionGroups/" + l.CollectionName and won't refer to the specified database.
Changing this also sort of suggests that we should either be urlencoding those or prohibit slashes in the parameter.
Contributor
|
🤖 Vercel preview here: https://docs-fzoexdw6e-goteleport.vercel.app/docs/ver/preview |
espadolini
approved these changes
Oct 15, 2024
zmb3
approved these changes
Oct 15, 2024
public-teleport-github-review-bot
Bot
removed request for
fspmarshall,
kiosion,
mmcallister,
ptgott,
r0mant and
xinding33
Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
rosstimothy
force-pushed
the
tross/firestore_database
branch
from
3f2d4e6 to
ac67be2
Compare
Contributor
|
🤖 Vercel preview here: https://docs-r1xf9oz8p-goteleport.vercel.app/docs/ver/preview |
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Oct 15, 2024
Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
rosstimothy
added a commit
that referenced
this pull request
Oct 15, 2024
Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
rosstimothy
added a commit
that referenced
this pull request
Oct 15, 2024
Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
rosstimothy
added a commit
that referenced
this pull request
Oct 15, 2024
Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
rosstimothy
added a commit
that referenced
this pull request
Oct 15, 2024
Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
rosstimothy
added a commit
that referenced
this pull request
Oct 15, 2024
Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
mvbrock
pushed a commit
that referenced
this pull request
Oct 16, 2024
Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
) Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
) Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
) Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
) Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
) Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
) Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database. Closes #37227.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firestore has supported multiple databases in a project for a while (see https://cloud.google.com/blog/products/databases/manage-multiple-firestore-databases-in-a-project), however, Teleport only allowed using the default database in the project. The DatabaseID is now exposed in the file config, and if provided both the state and events backends will use the appropriate database.
Closes #37227.
Changelog: Allow using a custom database for Firestore backends.