aws oidc skip aurora clusters without instances#47529
Merged
GavinFrazar merged 1 commit intomasterfrom Oct 15, 2024
Merged
Conversation
GavinFrazar
added
discover
marcoandredinis
approved these changes
Oct 14, 2024
Instead of returning an error, just skip the cluster that have no instances.
GavinFrazar
force-pushed
the
gavinfrazar/aurora-cluster-instance-not-found
branch
from
64e12df to
22b232f
Compare
probakowski
approved these changes
Oct 15, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from atburke
|
@GavinFrazar See the table below for backport results.
|
mvbrock
pushed a commit
that referenced
this pull request
Oct 16, 2024
Instead of returning an error, just skip the cluster that have no instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fixed an issue that prevented RDS Aurora discovery configuration in the AWS OIDC enrollment wizard when any cluster existed without member instances.
Closes #47197
database cluster <db-cluster> has no instance#47197Instead of returning an error, just skip the cluster(s) that have no instances.
If any cluster in a region/vpc had no member instances, then the enrollment wizard would fail to list all of the aurora clusters in that region/vpc. Now it lists the ones that have member instances instead of giving up.
I verified that this fix works in a manual test as well by deploying to my cloud staging tenant.