Implement auto-approvals for datadog#47475
Merged
bernardjkim merged 4 commits intomasterfrom Oct 16, 2024
Merged
Conversation
hugoShaka
reviewed
Oct 11, 2024
hugoShaka
reviewed
Oct 11, 2024
hugoShaka
reviewed
Oct 11, 2024
hugoShaka
reviewed
Oct 11, 2024
hugoShaka
reviewed
Oct 11, 2024
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
Looks good, thank you for adding the auto-approval capability into the common app.
- Use standard teleport.dev/schedules annotation - Link Datadog API docs
hugoShaka
reviewed
Oct 15, 2024
hugoShaka
approved these changes
Oct 15, 2024
marcoandredinis
approved these changes
Oct 15, 2024
|
@bernardjkim See the table below for backport results.
|
mvbrock
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Implement auto-approvals for datadog * Address feedback - Use standard teleport.dev/schedules annotation - Link Datadog API docs * Check annotations before api calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with https://github.com/gravitational/teleport.e/pull/5150
This PR extends the Datadog plugin to support automatic approvals.
Example Usage: A user with the following role will have access requests automatically approved if they are on-call for the
datadog-teamat the time of making the access request.changelog: Extend the Datadog plugin to support automatic approvals.