update bastion machine type to variable in AWS HA terraform#47297
update bastion machine type to variable in AWS HA terraform#47297stevenGravy merged 5 commits intomasterfrom
Conversation
stevenGravy
added
backport/branch/v14
no-changelog
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
So we broke the TF code by default for every x86 user 6 moths ago, but did not catch the issue until now because we default to ARM?
The new TF variable should be added to the Makefile and the README.
|
Also, this PR is changelog worthy. |
stevenGravy
removed
the
no-changelog
We don't put the other instance types (auth, proxy,...) though in the |
Thanks, changelog updated. |
The Makefile and README should contain every variable and mention if it's required or if we'll pick the default for the user. It's very likely that we missed adding variables there in the past. If you find missing vars, please add them to the reference 🙏 |
| // Instance type used for bastion server | ||
| variable "bastion_instance_type" { | ||
| type = string | ||
| default = "t4g.medium" |
There was a problem hiding this comment.
In the interest of having a more "friendly" experience for new users, maybe we could default this to null, then conditionally set the instance type deployed based off of the AMI architecture from data.aws_ami.base?
There was a problem hiding this comment.
I really like this idea, but think it's probably better implemented in a future PR as it'll require a fair bit more testing.
thanks @hugoShaka, please see update. |
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
LGTM, but I'd like @webvictim 's approval before merging.
public-teleport-github-review-bot
Bot
removed request for
klizhentas and
r0mant
webvictim
left a comment
webvictim
left a comment
There was a problem hiding this comment.
LGTM, just grammar/formatting nits
| // Instance type used for bastion server | ||
| variable "bastion_instance_type" { | ||
| type = string | ||
| default = "t4g.medium" |
There was a problem hiding this comment.
I really like this idea, but think it's probably better implemented in a future PR as it'll require a fair bit more testing.
Co-authored-by: Gus Luxton <gus@goteleport.com>
|
@stevenGravy See the table below for backport results.
|
5 participants
Sets to use a variable instance type instead of hard-coded. This currently causes problems if you specify a x86 AMI since that's not compatible with arm types.
changelog: Allow specifying the instance type of AWS HA Terraform bastion instance