[v16] fix: Always prompt if multiple MFA methods are running#47154
Merged
codingllama merged 1 commit intobranch/v16from Oct 7, 2024
Merged
[v16] fix: Always prompt if multiple MFA methods are running#47154codingllama merged 1 commit intobranch/v16from
codingllama merged 1 commit intobranch/v16from
Conversation
github-actions
Bot
added
backport
size/md
tsh
Contributor
Author
|
Conflicts on lib/client/mfa.go and tool/tsh/common/mfa.go, but nothing noteworthy - it's mostly git getting confused about unrelated new blocks on master. |
zmb3
approved these changes
Oct 3, 2024
marcoandredinis
approved these changes
Oct 4, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
* fix: Always prompt if multiple MFA methods are running * Fix deadlock on OTP+WebAuthn+PIN prompts * Fix races on wanwin.PromptPlatformMessage
codingllama
force-pushed
the
codingllama/backport/47114-v16
branch
from
ef4f74a to
1bee4f2
Compare
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #47114 to branch/v16.
#43072
Changelog: Fix missing tsh MFA prompt in certain OTP+WebAuthn scenarios