Skip to content

display all security group rules for a port range#47009

Merged
GavinFrazar merged 1 commit intomasterfrom
gavinfrazar/display-all-security-group-rules-per-port
Oct 1, 2024
Merged

display all security group rules for a port range#47009
GavinFrazar merged 1 commit intomasterfrom
gavinfrazar/display-all-security-group-rules-per-port

Conversation

@GavinFrazar
Copy link
Copy Markdown
Contributor

@GavinFrazar GavinFrazar commented Oct 1, 2024

Changelog: Fixed a bug where only one IP CIDR block security group rule for a port range was displayed in the web UI RDS enrollment wizard when viewing a security group.

Part of:

This fixes the web ui to display all of the rules for each port range.
There's another part to that issue that requires a change in the backend code so that we render security group reference rules, but that's for another PR.

UI Diff

I have an aws security group that has two rules, both of which allow inbound access from an IP address on postgres port 5432.

Before

sg-display-before

After

sg-display-after

@GavinFrazar GavinFrazar added discover Issues related to Teleport Discover backport/branch/v16 labels Oct 1, 2024
@GavinFrazar GavinFrazar requested a review from kimlisa October 1, 2024 05:00
@github-actions github-actions Bot requested review from kiosion and ravicious October 1, 2024 05:01
@GavinFrazar
Copy link
Copy Markdown
Contributor Author

GavinFrazar commented Oct 1, 2024

oh, realized that I need to fix the "View (<rule count>)" to count the rules properly.
I'll convert this to draft until I fix that.

@GavinFrazar GavinFrazar marked this pull request as draft October 1, 2024 05:07
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/display-all-security-group-rules-per-port branch from 1145dc5 to 7cad307 Compare October 1, 2024 05:25
@GavinFrazar GavinFrazar marked this pull request as ready for review October 1, 2024 05:27
@github-actions github-actions Bot requested review from avatus and rudream October 1, 2024 05:28
Comment thread web/packages/teleport/src/config.ts
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/display-all-security-group-rules-per-port branch from 7cad307 to cfc73cc Compare October 1, 2024 05:34
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/display-all-security-group-rules-per-port branch from cfc73cc to ba41382 Compare October 1, 2024 05:34
Comment thread web/packages/teleport/src/config.ts
Copy link
Copy Markdown
Contributor

@kimlisa kimlisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix!

@GavinFrazar GavinFrazar added this pull request to the merge queue Oct 1, 2024
Merged via the queue into master with commit 4e7292b Oct 1, 2024
@GavinFrazar GavinFrazar deleted the gavinfrazar/display-all-security-group-rules-per-port branch October 1, 2024 19:26
@public-teleport-github-review-bot
Copy link
Copy Markdown

@GavinFrazar See the table below for backport results.

Branch Result
branch/v16 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discover Issues related to Teleport Discover size/sm ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants