Skip to content

Enforce MFA for Admin Actions when OTP is disabled #46997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosstimothy merged 1 commit into from
Oct 1, 2024
Merged

Enforce MFA for Admin Actions when OTP is disabled #46997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api/types/authentication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,10 +372,10 @@ func (c *AuthPreferenceV2) IsSecondFactorWebauthnAllowed() bool {
c.Spec.SecondFactor == constants.SecondFactorOn
}

// IsAdminActionMFAEnforced checks if admin action MFA is enforced. Currently, the only
// prerequisite for admin action MFA enforcement is whether Webauthn is enforced.
// IsAdminActionMFAEnforced checks if admin action MFA is enforced.
func (c *AuthPreferenceV2) IsAdminActionMFAEnforced() bool {
return c.Spec.SecondFactor == constants.SecondFactorWebauthn
// OTP is not supported for Admin MFA.
return c.IsSecondFactorEnforced() && !c.IsSecondFactorTOTPAllowed()
}

// GetConnectorName gets the name of the OIDC or SAML connector to use. If
Expand Down