Skip to content

chore: Bump otel modules to v1.30.0/v0.55.0#46972

Merged
codingllama merged 1 commit intomasterfrom
codingllama/bump-otel
Sep 30, 2024
Merged

chore: Bump otel modules to v1.30.0/v0.55.0#46972
codingllama merged 1 commit intomasterfrom
codingllama/bump-otel

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Sep 30, 2024
@codingllama
Copy link
Copy Markdown
Contributor Author

@codingllama
Copy link
Copy Markdown
Contributor Author

Thanks for the quick reviews!

Comment thread api/go.mod
module github.com/gravitational/teleport/api

go 1.21
go 1.22
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - otel bumped their minimum Go version to 1.22

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otel now requires Go 1.22, so this gets updated automatically. Unavoidable if we want to move certain dependencies forward.

Copy link
Copy Markdown
Contributor Author

@codingllama codingllama Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Well spotted, btw. I meant to add a comment about it but it escaped me.)

@codingllama codingllama added this pull request to the merge queue Sep 30, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 30, 2024
@codingllama codingllama added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit d7591b2 Sep 30, 2024
@codingllama codingllama deleted the codingllama/bump-otel branch September 30, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants