Take the file path from webUtils.getPathForFile instead of File.path#46971
Merged
Take the file path from webUtils.getPathForFile instead of File.path#46971
webUtils.getPathForFile instead of File.path#46971Conversation
zmb3
approved these changes
Sep 30, 2024
avatus
approved these changes
Sep 30, 2024
public-teleport-github-review-bot
Bot
removed request for
ravicious and
rudream
This was referenced Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46889
Starting from Electron 32,
File.pathwas removed (unfortunately it's still in Electron types). We need to exposewebUtils.getPathForFilefrom the preload script to read the filepath and then pass it to tsh.Changelog: Fixed the "source path is empty" error when attempting to upload a file in Teleport Connect