fix: Enforce device trust on OSS processes#46940
Merged
codingllama merged 2 commits intomasterfrom Sep 27, 2024
Merged
Conversation
tigrato
approved these changes
Sep 27, 2024
Contributor
Author
|
Friendly ping @gabrielcorado. |
zmb3
approved these changes
Sep 27, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from gabrielcorado
Contributor
Author
|
Thanks for the quick reviews, folks. |
|
@codingllama See the table below for backport results.
|
This was referenced Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce a global "device_trust.mode=required" on OSS processes paired with an Enterprise Auth. This avoids a fail-open problem where an OSS node is paired with an Enterprise Auth, as previously the OSS node would interpret the device mode as "off" regardless of the actual setting.
Setting "device_trust.mode=required" on an OSS Auth is still an error, so it shouldn't be possible to see this particular config on a pure OSS cluster.
Changelog: Enforce a global "device_trust.mode=required" on OSS processes paired with an Enterprise Auth