Teleterm: Add listing kube resources endpoint#46753
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
kimlisa
commented
Sep 19, 2024
kimlisa
added
no-changelog
gzdunek
reviewed
Sep 19, 2024
ravicious
reviewed
Sep 20, 2024
kimlisa
force-pushed
the
lisa/teleterm-kube-resource-endpoint
branch
from
86815ca to
5ee774f
Compare
gzdunek
approved these changes
Sep 30, 2024
kimlisa
force-pushed
the
lisa/teleterm-kube-resource-endpoint
branch
5 times, most recently
from
34aadea to
ecc4409
Compare
kimlisa
force-pushed
the
lisa/teleterm-kube-resource-endpoint
branch
2 times, most recently
from
724eb86 to
6251b55
Compare
ravicious
approved these changes
Oct 8, 2024
| return generatePath( | ||
| paths.kubeResourceNamespaceLeaf, | ||
| params as any | ||
| ) as string; |
Member
There was a problem hiding this comment.
Suggested change
| ) as string; | |
| ) as LeafClusterKubeResourceNamespaceUri; |
| params as any | ||
| ) as string; | ||
| } else { | ||
| return generatePath(paths.kubeResourceNamespace, params as any) as string; |
Member
There was a problem hiding this comment.
Suggested change
| return generatePath(paths.kubeResourceNamespace, params as any) as string; | |
| return generatePath(paths.kubeResourceNamespace, params as any) as KubeResourceNamespaceUri; |
Contributor
Author
There was a problem hiding this comment.
think you meant RootClusterKubeResourceNamespaceUri, so i went with that
| } | ||
|
|
||
| // AppendKubeResourceNamespace appends kube resource namespace segment to the URI. | ||
| func (r ResourceURI) AppendKubeResourceNamespace(kubeClusterName string, kubeNamespaceName string) ResourceURI { |
Member
There was a problem hiding this comment.
I think this should accept just kubeNameSpaceName string as an argument, with the intention that if you want to make a URI to a kube namespace, you'd do something like uri.NewClusterURI(profileName).AppendKube(kubeClusterName).AppendKubeNamespace(kubeNamespaceName).
AppendLeafCluster already follows a similar approach, though AppendKubeResourceNamespace does not need to handle that extra case with name == "" like AppendLeafCluster does.
| return nil, trace.Wrap(err) | ||
| } | ||
|
|
||
| var proxyGRPCClient kubeproto.KubeServiceClient |
Member
There was a problem hiding this comment.
This is no longer needed, as in the client can just stay defined within AddMetadataToRetryableError. Maybe we could also name it kubenetesServiceClient or something along those lines? proxyGRPCClient makes it sound like it's used for more than just k8s, but it's actually heavily focused on k8s only.
3 tasks
kimlisa
force-pushed
the
lisa/teleterm-kube-resource-endpoint
branch
from
6251b55 to
21bed0c
Compare
Collaborator
|
/excludeflake * |
kimlisa
force-pushed
the
lisa/teleterm-kube-resource-endpoint
branch
from
4dda04e to
e4c646e
Compare
kimlisa
added a commit
that referenced
this pull request
Oct 9, 2024
* Rename makeLabels into MakeUILabelsWithoutInternalPrefixes * Teleterm: add listing kube resource endpoint * Teleterm pb updates * Renames, moves test, fix imports, address CRS
mvbrock
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Rename makeLabels into MakeUILabelsWithoutInternalPrefixes * Teleterm: add listing kube resource endpoint * Teleterm pb updates * Renames, moves test, fix imports, address CRS
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Teleterm: Add listing kube resources endpoint (#46753) * Rename makeLabels into MakeUILabelsWithoutInternalPrefixes * Teleterm: add listing kube resource endpoint * Teleterm pb updates * Renames, moves test, fix imports, address CRS * Straggling file from make grpc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #46742
easier to review by commit
Adds a new grpc endpoint and related boilerplates for listing kube resources
if confused what is the difference between the other endpoint where we list kubes, kube resources refers to kube_cluster's sub resources:
teleport/api/types/constants.go
Line 1233 in 110b23a