Merged
Conversation
bernardjkim
added
no-changelog
marcoandredinis
approved these changes
Sep 19, 2024
| return trace.Wrap(err) | ||
| } | ||
|
|
||
| staticCreds := p.Credentials.GetStaticCredentialsRef() |
Contributor
There was a problem hiding this comment.
I was trying to understand how the static credentials ref work, and I'm not entirely sure I understood everything, so take this with a grain of salt.
Do we need to extend the PluginStaticCredentials to have a new method that returns two Keys? So that we can return the API Key and the Application Key that is required to set up the Datadog access plugin?
Contributor
Author
There was a problem hiding this comment.
I believe the static credentials reference can be used as a reference to a set of credentials. You can check the follow up PR in lib/web/plugindescriptor.go to see how this is done https://github.com/gravitational/teleport.e/pull/4992 .
hugoShaka
approved these changes
Sep 19, 2024
public-teleport-github-review-bot
Bot
removed request for
r0mant,
rudream and
ryanclark
|
@bernardjkim See the table below for backport results.
|
bernardjkim
added a commit
that referenced
this pull request
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #46271.
This PR adds the API for the Datadog plugin settings. This is required to support the hosted version of the plugin.