[kube] support filtering for entire objects in tables#46683
Merged
Conversation
fspmarshall
approved these changes
Sep 17, 2024
dboslee
approved these changes
Sep 17, 2024
hugoShaka
reviewed
Sep 17, 2024
This PR fixes a bug where Teleport incorrectly returned an error when ordering resources by some field because the returned table included the full object instead of the PartialMetadataObject. This PR extends support for ordering fields by a field that isn't present in default table view.
tigrato
force-pushed
the
tigrato/fix-kube-assertion
branch
from
5f6fece to
abc19dc
Compare
hugoShaka
approved these changes
Sep 17, 2024
public-teleport-github-review-bot
Bot
removed request for
marcoandredinis and
strideynet
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Sep 17, 2024
smallinsky
pushed a commit
that referenced
this pull request
Sep 20, 2024
* [kube] support filtering for entire objects in tables This PR fixes a bug where Teleport incorrectly returned an error when ordering resources by some field because the returned table included the full object instead of the PartialMetadataObject. This PR extends support for ordering fields by a field that isn't present in default table view. * add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug where Teleport incorrectly returned an error when a request attempted to order resources by a field that wasn't included in the
*metav1.PartialObjectMetadataobjects returned in the table during akubectl get resourceoperation.Changelog: Fixes a bug in Kubernetes access that causes the error
expected *metav1.PartialObjectMetadata objectwhen trying to list resources.