[v16] Adding better error logging when roles block host user creation#46501
Merged
eriktate merged 1 commit intobranch/v16from Sep 11, 2024
Merged
[v16] Adding better error logging when roles block host user creation#46501eriktate merged 1 commit intobranch/v16from
eriktate merged 1 commit intobranch/v16from
Conversation
…cking for create_host_user_mode and surfacing for helpful error logging server side
eriktate
added
the
no-changelog
github-actions
Bot
requested review from
camscale,
nklaassen and
rosstimothy
rosstimothy
approved these changes
Sep 11, 2024
hugoShaka
approved these changes
Sep 11, 2024
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
Should we add a changelog entry?
public-teleport-github-review-bot
Bot
removed request for
camscale and
nklaassen
Contributor
Author
I left it off because the change didn't seem significant enough to me 😅 @rosstimothy do you think we should have a changelog for this? |
Contributor
We should at least note that we are fixing #46252 in the changelog |
eriktate
removed
the
no-changelog
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #46091 to branch/v16
changelog: Fixed an issue preventing session joining while host user creation was in use.