Skip to content

Revert "Remove findDOMNode usage from Modal and Popover"#46398

Merged
ravicious merged 1 commit intomasterfrom
r7s/revert-modal-changes
Sep 9, 2024
Merged

Revert "Remove findDOMNode usage from Modal and Popover"#46398
ravicious merged 1 commit intomasterfrom
r7s/revert-modal-changes

Conversation

@ravicious
Copy link
Copy Markdown
Member

This reverts commit 50ad928 (PR #46123) because it's causing certain modals to go into an infinite loop. This also breaks CI. See #46123 (comment) for more context and links.

@ravicious ravicious added the no-changelog Indicates that a PR does not require a changelog entry label Sep 9, 2024
@ravicious ravicious requested a review from bl-nero September 9, 2024 17:22
@ravicious ravicious enabled auto-merge September 9, 2024 17:22
@github-actions github-actions Bot requested review from kimlisa and rudream September 9, 2024 17:22
Copy link
Copy Markdown
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bot

@ravicious ravicious added this pull request to the merge queue Sep 9, 2024
Merged via the queue into master with commit b5f5656 Sep 9, 2024
@ravicious ravicious deleted the r7s/revert-modal-changes branch September 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/md ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants