Machine ID: Generate "includable" ssh_configs#46397
Merged
strideynet merged 8 commits intomasterfrom Sep 17, 2024
Merged
Conversation
timothyb89
approved these changes
Sep 17, 2024
Contributor
timothyb89
left a comment
There was a problem hiding this comment.
Working well on my local cluster!
ryanclark
approved these changes
Sep 17, 2024
…-ssh-config-output-tbot
|
@strideynet See the table below for backport results.
|
This was referenced Sep 17, 2024
smallinsky
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Hack on single-cluster SSH config * Update callsite * More thorough testing and adjusted header * Switch to warn level message * Update golden files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46330
Adds a
ssh_configandknown_hostper cluster:example.teleport.sh.ssh_configexample.teleport.sh.known_hostsThese do not use the host matcher directive as the current configs do, this means that you are able to specify a host using it's bare hostname e.g "my-machine.foo" and with it's cluster appended hostname e.g "my-machine.foo.example.teleport.sh". This also opens the door to better supporting ProxyTemplates in the near future.
As these do not include the host matcher, it allows the user to define their own
ssh_configand include thisssh_configusing the Include directive, allowing for more flexible configurations.changelog: Machine ID now generates cluster-specific
ssh_configandknown_hostfiles which will always direct SSH connections made using them via Teleport.