Skip to content

Make the Slack chart embed tbot#46353

Merged
hugoShaka merged 13 commits intomasterfrom
hugo/slack-chart-source-tbot
Sep 12, 2024
Merged

Make the Slack chart embed tbot#46353
hugoShaka merged 13 commits intomasterfrom
hugo/slack-chart-source-tbot

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka commented Sep 6, 2024 •
edited
Loading

Changelog: The teleport-plugin-slack chart can now deploy tbot to obtain and renew the Slack plugin credentials automatically. This setup is easier and more secure than signing long-lived credentials.

This PR makes the access/slack chart able to dynamically include the tbot chart and request credentials.

This offers a better UX for users as they don't have to figure out the glue on their own. Once merged, we should update the slack guides.

Example deployment:

slack:
  token: xoxb-...

roleToRecipients:
  "*": ["#testing"]

tbot:
  enabled: true
  clusterName: example.teleport.sh
  teleportProxyAddress: example.teleport.sh:443
  joinMethod: token
  token: <INSERT TOKEN HERE>

If we're happy with this chart, the same changes should be ported to all integration charts (access plugins and event handler).

@hugoShaka hugoShaka mentioned this pull request Sep 6, 2024
Merged
hugoShaka
hugoShaka commented Sep 6, 2024
View reviewed changes
Comment thread examples/chart/access/slack/charts/tbot-17.0.0-dev.tgz Outdated
Comment thread examples/chart/access/slack/Chart.yaml Outdated
@hugoShaka hugoShaka requested a review from strideynet September 6, 2024 18:37
Base automatically changed from strideynet/tbot-helm-chart to master September 9, 2024 10:58
@strideynet
Copy link
Copy Markdown
Contributor

strideynet commented Sep 10, 2024

Love the look of this!

@hugoShaka hugoShaka force-pushed the hugo/slack-chart-source-tbot branch from a4b1a3a to 669d927 Compare September 10, 2024 14:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 10, 2024

🤖 Vercel preview here: https://docs-ioky48hjw-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 10, 2024

🤖 Vercel preview here: https://docs-o5h3ccfms-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 10, 2024

🤖 Vercel preview here: https://docs-hawuymuld-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 10, 2024

🤖 Vercel preview here: https://docs-fldl7nrz3-goteleport.vercel.app/docs/ver/preview

hugoShaka
hugoShaka commented Sep 10, 2024
View reviewed changes
Comment thread Makefile
Comment on lines +862 to +866
helm unittest -3 --with-subchart=false examples/chart/teleport-kube-agent
helm unittest -3 --with-subchart=false examples/chart/teleport-cluster/charts/teleport-operator
helm unittest -3 --with-subchart=false examples/chart/access/*
helm unittest -3 --with-subchart=false examples/chart/event-handler
helm unittest -3 --with-subchart=false examples/chart/tbot
Copy link
Copy Markdown
Contributor Author

@hugoShaka hugoShaka Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required for chart inclusion, else the unittest plugin tries to test the included chart twice and it cannot find the snapshots for the child chart in the parent test directory.

@hugoShaka hugoShaka marked this pull request as ready for review September 10, 2024 15:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 10, 2024

🤖 Vercel preview here: https://docs-1fd22iklr-goteleport.vercel.app/docs/ver/preview

strideynet
strideynet approved these changes Sep 10, 2024
View reviewed changes
Comment thread examples/chart/access/slack/templates/_helpers.tpl Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 10, 2024

🤖 Vercel preview here: https://docs-onbfqribu-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 10, 2024

🤖 Vercel preview here: https://docs-qkkosdcca-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2024

🤖 Vercel preview here: https://docs-4tcwny0v7-goteleport.vercel.app/docs/ver/preview

@hugoShaka hugoShaka enabled auto-merge September 12, 2024 22:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2024

🤖 Vercel preview here: https://docs-7nfj5t00j-goteleport.vercel.app/docs/ver/preview

@hugoShaka hugoShaka added this pull request to the merge queue Sep 12, 2024
Merged via the queue into master with commit 40e4f10 Sep 12, 2024
@hugoShaka hugoShaka deleted the hugo/slack-chart-source-tbot branch September 12, 2024 22:49
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Sep 12, 2024

@hugoShaka See the table below for backport results.

Branch Result
branch/v16 Create PR

@hugoShaka hugoShaka mentioned this pull request Sep 13, 2024
Merged
@strideynet strideynet mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigrato tigrato tigrato approved these changes

@strideynet strideynet strideynet approved these changes

@ptgott ptgott ptgott approved these changes

Assignees

No one assigned

Labels

documentation helm size/md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugoShaka @strideynet @tigrato @ptgott