Make k8s permissions test optional #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
webvictim
reviewed
Oct 22, 2020
awly
force-pushed
the
andrew/kube_impersonation_check_optional
branch
2 times, most recently
from
0aa1913 to
7591d3c
Compare
webvictim
reviewed
Oct 22, 2020
| @@ -91,6 +91,9 @@ type ForwarderConfig struct { | |||
| // PingPeriod is a period for sending ping messages on the incoming | |||
| // connection. | |||
| PingPeriod time.Duration | |||
| // StrictImpersonationCheck specifies whether to fail when impersonation | |||
| // permissions of this forwarder can't be tested. | |||
| StrictImpersonationCheck bool | |||
There was a problem hiding this comment.
Do we need to set a default value for this somewhere?
There was a problem hiding this comment.
The default is the zero value (false).
This will only be set to true in the new kubernetes_service (when it's ready #4611).
There are several legitimate cases where it can fail: - root proxy running inside k8s but without access to local k8s cluster - root proxy running with a dummy kubeconfig that we recommended in the past Leave a ForwarderConfig flag to enforce this check, it will be useful in kubernetes_service later that should always have the right permissions.
Co-authored-by: Gus Luxton <[email protected]>
awly
force-pushed
the
andrew/kube_impersonation_check_optional
branch
from
7591d3c to
bf28d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several legitimate cases where it can fail:
past
Leave a ForwarderConfig flag to enforce this check, it will be useful in
kubernetes_service later that should always have the right permissions.