Skip to content

Remove findDOMNode usage from Modal and Popover #46123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravicious merged 11 commits into from
Sep 9, 2024
Merged

Remove findDOMNode usage from Modal and Popover #46123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
da7edf4
Remove disablePortal prop
ravicious Aug 30, 2024
731f1be
Get rid of ownerDocument and ownerWindow
ravicious Aug 30, 2024
e6a1594
Remove container prop for Modal, replace Portal with createPortal
ravicious Aug 30, 2024
fa8f689
Refactor Modal to use TypeScript
ravicious Sep 2, 2024
95d5e3b
Remove RootRef
ravicious Sep 2, 2024
96dfd85
Remove findDOMNode from Popover
ravicious Sep 2, 2024
4c5478c
Fix types for mouse & keyboard events
ravicious Sep 6, 2024
a0bc96e
Insert whitespace between prop type declarations
ravicious Sep 6, 2024
77fc4ce
Remove link from BackdropProps comment
ravicious Sep 6, 2024
cd008fa
Extract type for BackdropProps
ravicious Sep 6, 2024
f2ae835
Add JSDoc for children prop
ravicious Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading