Merged
Conversation
rosstimothy
approved these changes
Aug 31, 2024
espadolini
approved these changes
Sep 2, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from EdwardDowling
fspmarshall
force-pushed
the
fspmarshall/fix-local-reregister
branch
from
210043c to
cf9b9fc
Compare
|
@fspmarshall See the table below for backport results.
|
This was referenced Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced in #41467 which could cause reissue of certificates to fail for a service which was running alongside a local auth server, had a listener bound to
0.0.0.0, and did not haveadvertise_ipset. With this change, local re-register takes on the same behavior as local register, using127.0.0.1as the default remote address value.Fixes #43856
changelog: fixed an issue that would cause reissue of certificates to fail in some scenarios where a local auth service was present.