[v16] Machine ID: Terraform Cloud joining (#45574)#46049
Merged
timothyb89 merged 7 commits intobranch/v16from Sep 18, 2024
Merged
[v16] Machine ID: Terraform Cloud joining (#45574)#46049timothyb89 merged 7 commits intobranch/v16from
timothyb89 merged 7 commits intobranch/v16from
Conversation
Backport of #45574 for branch/v16 --- * Machine ID: Terraform Cloud joining This adds a new `terraform` join method, which uses Terraform Cloud's Workload Identity OIDC provider to provide delegated joining support for Machine ID bots. As the Terraform provider now embeds tbot, this means - with some light modifications - that the Terraform provider can now join using this join method, and without any secrets. * Address some review feedback, add first batch of tests This addresses a few feedback items, defaulting the audience to the Teleport cluster name and requiring allow rules specify an organization + at least one other parameter. Also, adds a first batch of tests. * Update autogenerated CRD docs * Add tests for RegisterUsingToken and provisioning token init * Fix imports * Fix CRD docs * Update tfschema * Update tf docs * Update docstring to make it clear that `Audience` is optional * Update manifests * Update CRD docs * Code review feedback; docstring fixes * Rename lib/terraform to lib/terraformcloud * Rename terraform -> terraform_cloud Renames the new join method to terraform_cloud to make it clear that it won't work for TF running elsewhere (where other join methods should be used) * Fix tests and docs lints * Update api/proto/teleport/legacy/types/types.proto Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> * Update proto artifacts --------- Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
Contributor
|
🤖 Vercel preview here: https://docs-bz640x8vn-goteleport.vercel.app/docs/ver/preview |
timothyb89
changed the title
…terraform-cloud-joining
This adds support for hostname/issuer overrides, needed to support on-prem Terraform Enterprise installs. When the new `hostname` field is unset, behavior is changed, but when set, the JWT is validated against it instead of `app.terraform.io`. Additionally, this renames `join_terraform.go` to `join_terraformcloud.go`, since that was missed during the rename in #45574.
* Terraform Cloud joining: Support Terraform Enterprise issuers This adds support for hostname/issuer overrides, needed to support on-prem Terraform Enterprise installs. When the new `hostname` field is unset, behavior is changed, but when set, the JWT is validated against it instead of `app.terraform.io`. Additionally, this renames `join_terraform.go` to `join_terraformcloud.go`, since that was missed during the rename in #45574. * Enable Terraform Cloud joining for Teleport Community Edition This enables Terraform Cloud joining for Community Edition when using the public HCP Terraform SaaS. Teleport Enterprise is still required for use with self-hosted Terraform Enterprise. changelog: Enable Terraform Cloud joining for Teleport Community Edition when using HCP Terraform * Fix unit tests * Update lib/auth/join_terraformcloud.go Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> * Fix linter --------- Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
Contributor
|
🤖 Vercel preview here: https://docs-ckn0xc3cx-goteleport.vercel.app/docs/ver/preview |
Contributor
|
🤖 Vercel preview here: https://docs-qzvq3ales-goteleport.vercel.app/docs/ver/preview |
|
@timothyb89 - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
strideynet
approved these changes
Sep 17, 2024
Contributor
Author
|
I published a dev build with this change,
These can be used alongside the public docs and my gist to configure a local Terraform Cloud project to use on-disk binaries. |
tigrato
approved these changes
Sep 17, 2024
…terraform-cloud-joining
Contributor
|
🤖 Vercel preview here: https://docs-jzi584llm-goteleport.vercel.app/docs/ver/preview |
marcoandredinis
approved these changes
Sep 18, 2024
zmb3
approved these changes
Sep 18, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from mmcallister
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
…terraform-cloud-joining
Contributor
|
🤖 Vercel preview here: https://docs-3g6xuxlb3-goteleport.vercel.app/docs/ver/preview |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #45574 for branch/v16
changelog: Add new
terraform_cloudjoining method to enable secretless authentication on HCP Terraform jobs for the Teleport Terraform providerThis adds a new
terraformjoin method, which uses Terraform Cloud's Workload Identity OIDC provider to provide delegated joining support for Machine ID bots. As the Terraform provider now embeds tbot, this means - with some light modifications - that the Terraform provider can now join using this join method, and without any secrets.This addresses a few feedback items, defaulting the audience to the Teleport cluster name and requiring allow rules specify an organization + at least one other parameter.
Also, adds a first batch of tests.
Update autogenerated CRD docs
Add tests for RegisterUsingToken and provisioning token init
Fix imports
Fix CRD docs
Update tfschema
Update tf docs
Update docstring to make it clear that
Audienceis optionalUpdate manifests
Update CRD docs
Code review feedback; docstring fixes
Rename lib/terraform to lib/terraformcloud
Rename terraform -> terraform_cloud
Renames the new join method to terraform_cloud to make it clear that it won't work for TF running elsewhere (where other join methods should be used)
Fix tests and docs lints
Update api/proto/teleport/legacy/types/types.proto
Update proto artifacts