Merged
Conversation
Collaborator
|
Did we ever release the V1 resource? If not, can we make these changes without introducing a V2? |
Contributor
The proto linter makes no exceptions for unreleased protos. The only way to achieve that would be to delete v1 and add it back. |
EdwardDowling
approved these changes
Aug 30, 2024
espadolini
reviewed
Sep 2, 2024
rosstimothy
reviewed
Sep 3, 2024
Contributor
rosstimothy
left a comment
There was a problem hiding this comment.
Will we be deleting v1 since it's not intended to be used and was never released?
rosstimothy
approved these changes
Sep 3, 2024
2252866 to
f1d68ca
Compare
espadolini
approved these changes
Sep 4, 2024
rosstimothy
reviewed
Sep 4, 2024
f1d68ca to
6ac7b71
Compare
This change adds the v2 static host user resource.
6ac7b71 to
3376324
Compare
atburke
added a commit
that referenced
this pull request
Sep 4, 2024
This change adds the v2 static host user resource.
atburke
added a commit
that referenced
this pull request
Sep 10, 2024
This change adds the v2 static host user resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the v2 static host user resource.
In the v1 resource, more than one SHU resource with the same login but with conflicting other fields (groups, uid/gid, etc) could apply to a node. The host user's expected configuration would be ambiguous and sensitive to the order in which the resources were created.
In the v2 resource, only one resource can exist per login (the login is now the resource name to enforce this). The SHU resource contains a list of matchers to apply different configurations to different nodes:
If more than one matcher applies to the node, the node can reject the host user without needing to know about any other SHU resources.
Static host users aren't in any releases yet, so no need to worry about breaking changes.
Part of #42712.