revert from using grpc.NewClient to grpc.Dial#46006
Merged
GavinFrazar merged 1 commit intomasterfrom Aug 29, 2024
Merged
Conversation
tigrato
approved these changes
Aug 29, 2024
smallinsky
approved these changes
Aug 29, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from vapopov
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@GavinFrazar See the table below for backport results.
|
This was referenced Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: fixed a bug where Teleport services could not join the cluster using iam, azure, or tpm methods when the proxy service certificate did not contain IP SANs.
This PR reverts the change from
grpc.Dialtogrpc.NewClientin #44324ReportSecretsforwarder to proxy's gRPC insecure server #44324grpc.Dialis being deprecated in favor ofgrpc.NewClient, but there's an issue wheregrpc.NewClientresolves the proxy address to an IP and then fails to verify the proxy cert if it does not contain the IP SAN: grpc/grpc-go#7556