Merged
Conversation
ryanclark
approved these changes
Aug 28, 2024
zmb3
approved these changes
Aug 28, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from kiosion
zmb3
reviewed
Aug 28, 2024
Collaborator
There was a problem hiding this comment.
windows-dark.svg is still using the "trapezoid" logo. Should we be consistent?
Contributor
Author
There was a problem hiding this comment.
Yeah. the resource icons don't actually use the windows dark anywhere but I will update
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This update the kubeserver, server, application, and desktop icons to the new, shadowless version
avatus
force-pushed
the
avatus/fix_icons
branch
from
bfcc94e to
4f7f068
Compare
Contributor
Author
|
Note: the resources cards will still use the Kube logo to better distinguish from servers (per UX team). I've updated the kubeserver logo in this PR but I don't believe it is actually used anywhere in the app. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will update the kubeserver, server, application, and desktop icons to the new, shadowless version
Note: the resources cards will still use the Kube logo to better distinguish from servers (per UX team). I've updated the kubeserver logo in this PR but I don't believe it is actually used anywhere in the app.
I browsed every resource type in my cluster (which is at least one of every type in the unified cache) and the icons all are shadowless and seem to have matching styles now.
Happy to add on any other icon changes we might need to this PR if anyone finds anything else lingering
changelog: Updated the icons for server, application, and desktop resources