Skip to content

[v16] Migrate S3 uploader to aws-sdk-go-v2#45648

Closed
rudream wants to merge 4 commits intobranch/v16from
bot/backport-44728-branch/v16
Closed

[v16] Migrate S3 uploader to aws-sdk-go-v2#45648
rudream wants to merge 4 commits intobranch/v16from
bot/backport-44728-branch/v16

Conversation

@rudream
Copy link
Copy Markdown
Contributor

@rudream rudream commented Aug 20, 2024

Backport #44728 to branch/v16

This also includes backports of:

Mostly clean cherry-picks apart from changes to backend/dynamo/dynamobbk.go (I ended up just replacing the whole file with the current version of it from master)

@rudream rudream added the no-changelog Indicates that a PR does not require a changelog entry label Aug 20, 2024
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log backport size/sm labels Aug 20, 2024
@github-actions github-actions bot requested review from rosstimothy and zmb3 August 20, 2024 21:13
@rosstimothy
Copy link
Copy Markdown
Contributor

The github.com/gravitational/teleport/lib/observability/metrics/aws metrics middleware added in #44376 have not yet been backported to v16. You'll want to include them in this backport.

@rudream rudream force-pushed the bot/backport-44728-branch/v16 branch from 3d243df to b49b907 Compare August 21, 2024 18:34
@rudream
Copy link
Copy Markdown
Contributor Author

rudream commented Aug 22, 2024

Closing because we decided not to backport this.

@rudream rudream closed this Aug 22, 2024
@rudream rudream deleted the bot/backport-44728-branch/v16 branch August 23, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-log Issues related to Teleports Audit Log backport no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants