Conversation
atburke
added
no-changelog
rosstimothy
reviewed
Aug 16, 2024
EdwardDowling
approved these changes
Aug 19, 2024
rosstimothy
reviewed
Aug 19, 2024
| collections.byKind[resourceKind] = collections.kubeWaitingContainers | ||
| case types.KindStaticHostUser: | ||
| if c.StaticHostUsers == nil { | ||
| return nil, trace.BadParameter("mising parameter StaticHostUsers") |
Contributor
There was a problem hiding this comment.
Suggested change
| return nil, trace.BadParameter("mising parameter StaticHostUsers") | |
| return nil, trace.BadParameter("missing parameter StaticHostUsers") |
Contributor
|
It looks like TestNodeCAFiltering needs to be updated to populate the static host users service. |
rosstimothy
approved these changes
Aug 19, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
This change adds cache support for static host users.
atburke
force-pushed
the
atburke/static-user-cache
branch
from
bfc288c to
2510cb7
Compare
atburke
added a commit
that referenced
this pull request
Sep 10, 2024
This change adds cache support for static host users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds cache support for static host users.
Part of #42712.