Conversation
zmb3
approved these changes
Aug 16, 2024
Collaborator
|
Does this need to go to v15 as well? |
avatus
approved these changes
Aug 16, 2024
public-teleport-github-review-bot
Bot
removed request for
gzdunek,
ryanclark and
webvictim
webvictim
approved these changes
Aug 16, 2024
This was referenced Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a regression for the
FeatureHidingfeature which, when enabled, is supposed to hide the management tab from users with no access to anything within it.This regression was introduced in this PR: #36368, when we implemented the top bar, we forgot to use the
managementSectionflag to conditionally render the management navigation section.This PR also adds some missing features to the exclusion list.
Demo
User with no access to any management features &
FeatureHidingonchangelog: Fixed bug causing FeatureHiding flag to not hide the "Access Management" section in the UI as intended.