Skip to content

[v16] fix: Avoid t.TempDir() for unix socket paths #45539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codingllama merged 1 commit into from
Aug 15, 2024
Merged

[v16] fix: Avoid t.TempDir() for unix socket paths #45539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions lib/client/api_login_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,9 +507,20 @@ func newStandaloneTeleport(t *testing.T, clock clockwork.Clock) *standaloneBundl
require.NoError(t, err)
user.AddRole(role.GetName())

// Use os.MkdirTemp() instead of t.TempDir() for the DataDir.
// The shorter temp paths avoid problems with long unix socket paths composed
// using the DataDir.
// See https://github.com/golang/go/issues/62614.
makeDataDir := func() string {
tempDir, err := os.MkdirTemp("", "teleport-test-")
require.NoError(t, err, "os.MkdirTemp failed")
t.Cleanup(func() { os.RemoveAll(tempDir) })
return tempDir
}

// AuthServer setup.
cfg := servicecfg.MakeDefaultConfig()
cfg.DataDir = t.TempDir()
cfg.DataDir = makeDataDir()
cfg.Hostname = "localhost"
cfg.Clock = clock
cfg.Console = console
Expand Down Expand Up @@ -591,7 +602,7 @@ func newStandaloneTeleport(t *testing.T, clock clockwork.Clock) *standaloneBundl

// Proxy setup.
cfg = servicecfg.MakeDefaultConfig()
cfg.DataDir = t.TempDir()
cfg.DataDir = makeDataDir()
cfg.Hostname = "localhost"
cfg.SetToken(staticToken)
cfg.Clock = clock
Expand Down