fix: Avoid t.TempDir() for unix socket paths#45529
Merged
codingllama merged 1 commit intomasterfrom Aug 15, 2024
Merged
Conversation
codingllama
added
backport/branch/v14
no-changelog
Contributor
Author
|
When I change the go.mod version to 1.23 I consistently hit this error on TestTeleportClient_DeviceLogin. Might be bad luck, or might be a blocker for Go 1.23. Edit: other tests are liable to break too, the one above is only the first. |
tigrato
reviewed
Aug 15, 2024
codingllama
force-pushed
the
codingllama/unix-socket-tempdir
branch
from
8b19d24 to
606d42a
Compare
tigrato
approved these changes
Aug 15, 2024
rosstimothy
approved these changes
Aug 15, 2024
|
@codingllama See the table below for backport results.
|
This was referenced Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a failure due to long unix socket paths on macOS.
See golang/go#62614.