Skip to content

Client tools RFD update#45515

Merged
vapopov merged 2 commits intorjones/client-toolsfrom
vapopov/client-tools-rfd-update
Aug 16, 2024
Merged

Client tools RFD update#45515
vapopov merged 2 commits intorjones/client-toolsfrom
vapopov/client-tools-rfd-update

Conversation

@vapopov
Copy link
Copy Markdown
Contributor

@vapopov vapopov commented Aug 15, 2024

In this PR added proposed changes from Agent autoupdate RFD

@vapopov vapopov requested review from russjones and sclevine August 15, 2024 02:00
@vapopov vapopov self-assigned this Aug 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions github-actions Bot added rfd Request for Discussion size/sm labels Aug 15, 2024
@vapopov
Copy link
Copy Markdown
Contributor Author

vapopov commented Aug 15, 2024

Should I add information about CDN used for client tools autoupdate?

@vapopov vapopov added the no-changelog Indicates that a PR does not require a changelog entry label Aug 15, 2024
@sclevine
Copy link
Copy Markdown
Member

tctl autoupdate watch and tctl autoupdate get will need a --proxy flag, to avoid needing to authenticate with a (potentially outdated) version of tbot/tsh.

Should I add information about CDN used for client tools autoupdate?

Might be worth adding, especially @russjones mentioned that we made need architecture-specific macos builds.

Copy link
Copy Markdown
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

There is one more edge case that we need to handle that a customer raised earlier in the week. What if the user does not use tsh for several months and is behind by multiple versions. In this case, during tsh login we should prompt the user that they need to re-run tsh login with --skip-version-check to allow tsh to hopefully catch up.

@vapopov vapopov merged commit dd62e80 into rjones/client-tools Aug 16, 2024
@vapopov vapopov deleted the vapopov/client-tools-rfd-update branch August 16, 2024 03:50
github-merge-queue Bot pushed a commit that referenced this pull request Jan 10, 2025
* Added RFD 0144 - Client Tools Updates

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Client tools RFD update (#45515)

* Add changes proposed for client autoupdate
* Add proxy flag and CDN info

* Naming adjustments

* Naming adjustments

* Update client tools autoupdate RFD (#47498)

* Drop watch command for autoupdate

* Add modified tctl commands and `find` endpoint response

* Add words to spell checker

---------

Co-authored-by: Vadym Popov <vadym.popov@goteleport.com>
carloscastrojumo pushed a commit to carloscastrojumo/teleport that referenced this pull request Feb 19, 2025
* Added RFD 0144 - Client Tools Updates

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Fix.

* Client tools RFD update (gravitational#45515)

* Add changes proposed for client autoupdate
* Add proxy flag and CDN info

* Naming adjustments

* Naming adjustments

* Update client tools autoupdate RFD (gravitational#47498)

* Drop watch command for autoupdate

* Add modified tctl commands and `find` endpoint response

* Add words to spell checker

---------

Co-authored-by: Vadym Popov <vadym.popov@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry rfd Request for Discussion size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants