Skip to content

[v15] chore: Bump golangci-lint to v1.60.1#45481

Merged
codingllama merged 4 commits intobranch/v15from
codingllama/backport/45469-v15
Aug 15, 2024
Merged

[v15] chore: Bump golangci-lint to v1.60.1#45481
codingllama merged 4 commits intobranch/v15from
codingllama/backport/45469-v15

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

Backport #45469 to branch/v15.

* chore: Bump golangci-lint to v1.60.1

* Fix new golangci-lint offenders

* Fix api/ lint offenders
@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Aug 14, 2024
@github-actions github-actions Bot added audit-log Issues related to Teleports Audit Log backport database-access Database access related issues and PRs discovery kubernetes-access size/sm tctl tctl - Teleport admin tool labels Aug 14, 2024
@codingllama codingllama enabled auto-merge August 14, 2024 16:18
@codingllama codingllama force-pushed the codingllama/backport/45469-v15 branch from c514dc3 to 5bfe0a5 Compare August 14, 2024 16:34
@codingllama
Copy link
Copy Markdown
Contributor Author

Applied some more fixes, should be clean now. PTAL.

@codingllama
Copy link
Copy Markdown
Contributor Author

There are a lot of testifylint errors on integrations/ tests, I've elected to ignore those than to change a bunch of test files (and create branch-specific changes in the process).

For example:

integrations/access/email/testlib/suite.go:104:1: suite-thelper: suite helper method must start with s.T().Helper() (testifylint)
func (s *EmailBaseSuite) startApp() {
^

@codingllama codingllama added this pull request to the merge queue Aug 15, 2024
Merged via the queue into branch/v15 with commit a7e0e8f Aug 15, 2024
@codingllama codingllama deleted the codingllama/backport/45469-v15 branch August 15, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-log Issues related to Teleports Audit Log backport database-access Database access related issues and PRs discovery kubernetes-access no-changelog Indicates that a PR does not require a changelog entry size/sm tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants