Fix firestore events interface and init stage. #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
approved these changes
Oct 14, 2020
lib/backend/firestore/firestorebk.go
Outdated
| select { | ||
| case <-time.After(timeInBetweenIndexCreationStatusChecks): | ||
| case <-ctx.Done(): | ||
| return trace.ConnectionProblem(ctx.Err(), "context timeout") |
There was a problem hiding this comment.
Suggested change
| return trace.ConnectionProblem(ctx.Err(), "context timeout") | |
| return trace.ConnectionProblem(ctx.Err(), "context timed out or canceled") |
fspmarshall
approved these changes
Oct 14, 2020
This comit fixes #4508 Gogoproto is not compatible with APIv2 protoc-gen-go. Track the issue here: gogo/protobuf#678 Meanwhile, this commit switches to google protobuf to unmarshal firebase struct. Add a missing method EmitAuditEvent causing teleport to crash with firestore events backend.
klizhentas
force-pushed
the
sasha/firestore-fix
branch
from
439cf29 to
13598de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comit fixes #4508
Gogoproto is not compatible with APIv2 protoc-gen-go.
Track the issue here: gogo/protobuf#678
Meanwhile, this commit switches to google protobuf to unmarshal firebase struct.
Add a missing method EmitAuditEvent causing teleport to crash
with firestore events backend.