Skip to content

Set the key id in JWT#45350

Merged
programmerq merged 3 commits intomasterfrom
jeff/fix-jwt-kid
Aug 21, 2024
Merged

Set the key id in JWT#45350
programmerq merged 3 commits intomasterfrom
jeff/fix-jwt-kid

Conversation

@programmerq
Copy link
Copy Markdown
Contributor

Some JWT libraries panic with multiple keys present in the JWKS. A second JWKS key entry was added in #40998

Fixes #44245

@programmerq programmerq added application-access no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels Aug 9, 2024
@github-actions github-actions Bot requested review from klizhentas and zmb3 August 9, 2024 21:22
Comment thread lib/jwt/jwt.go Outdated
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeff!

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from klizhentas August 19, 2024 14:51
programmerq and others added 2 commits August 19, 2024 15:04
Some JWT libraries panic with multiple keys present in the JWKS. A
second JWKS key entry was added in #40998

Fixes #44245
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@programmerq programmerq added this pull request to the merge queue Aug 21, 2024
Merged via the queue into master with commit 677ef0b Aug 21, 2024
@programmerq programmerq deleted the jeff/fix-jwt-kid branch August 21, 2024 14:02
@public-teleport-github-review-bot
Copy link
Copy Markdown

@programmerq See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed

@programmerq
Copy link
Copy Markdown
Contributor Author

The automatic backports failed due to differences in the master branch for the work done as part of the 17.x modern signature algorithm work.

Manual backports for 16.x and 15.x are still feasible.

strideynet pushed a commit that referenced this pull request Oct 9, 2024
* Set the key id in JWT

Some JWT libraries panic with multiple keys present in the JWKS. A
second JWKS key entry was added in #40998

Fixes #44245

* Update lib/jwt/jwt.go

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

* fix compile error

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
strideynet pushed a commit that referenced this pull request Oct 9, 2024
* Set the key id in JWT

Some JWT libraries panic with multiple keys present in the JWKS. A
second JWKS key entry was added in #40998

Fixes #44245

* Update lib/jwt/jwt.go

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

* fix compile error

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
github-merge-queue Bot pushed a commit that referenced this pull request Oct 10, 2024
* Set the key id in JWT

Some JWT libraries panic with multiple keys present in the JWKS. A
second JWKS key entry was added in #40998

Fixes #44245

* Update lib/jwt/jwt.go



* fix compile error

---------

Co-authored-by: Jeff Anderson <jeff@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
github-merge-queue Bot pushed a commit that referenced this pull request Oct 10, 2024
* Set the key id in JWT

Some JWT libraries panic with multiple keys present in the JWKS. A
second JWKS key entry was added in #40998

Fixes #44245

* Update lib/jwt/jwt.go



* fix compile error

---------

Co-authored-by: Jeff Anderson <jeff@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application-access no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JWT Missing KID Claim Results in Verification Issue

3 participants