fix: Assert credentials individually on U2F devices#45289
Merged
codingllama merged 5 commits intomasterfrom Aug 12, 2024
Merged
fix: Assert credentials individually on U2F devices#45289codingllama merged 5 commits intomasterfrom
codingllama merged 5 commits intomasterfrom
Conversation
Contributor
Author
|
Tested manually in various scenarios: login with multiple keys, registration with multiple keys, registration with device registered/not registered, login as single key, etc. A few logs added below. login with multiple keys: tsh mfa add (adding another key): tsh mfa add (already registered): login (only authenticator): |
Contributor
Author
|
@ravicious, would you mind cloning this branch and running a final local test to make sure the fix is solid? |
Contributor
Author
|
Re backports: I've no plans to backport this as of now. I don't like changing this logic much, so I would rather only do that after v17 testplans (or if someone else raises the issue). |
smallinsky
approved these changes
Aug 12, 2024
Contributor
Author
|
Friendly ping @gzdunek @ravicious ? |
ravicious
approved these changes
Aug 12, 2024
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
I tested this locally and these changes let me log in with the old key.
public-teleport-github-review-bot
Bot
removed the request for review
from gzdunek
Contributor
Author
|
Thanks everyone! |
Contributor
Author
|
FYI, I've moved the |
codingllama
added a commit
that referenced
this pull request
Nov 4, 2024
* Simulate "internal error" on multiple credentials * fix: Assert credentials individually on U2F devices * Use bytes.Repeat * Comment on U2F and libfido2.ErrUserPresenceRequired * Move errorOnUnknownCredential failure after the "tap"
codingllama
added a commit
that referenced
this pull request
Nov 4, 2024
* Simulate "internal error" on multiple credentials * fix: Assert credentials individually on U2F devices * Use bytes.Repeat * Comment on U2F and libfido2.ErrUserPresenceRequired * Move errorOnUnknownCredential failure after the "tap"
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Simulate "internal error" on multiple credentials * fix: Assert credentials individually on U2F devices * Use bytes.Repeat * Comment on U2F and libfido2.ErrUserPresenceRequired * Move errorOnUnknownCredential failure after the "tap"
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Simulate "internal error" on multiple credentials * fix: Assert credentials individually on U2F devices * Use bytes.Repeat * Comment on U2F and libfido2.ErrUserPresenceRequired * Move errorOnUnknownCredential failure after the "tap"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a somewhat rare error in older authenticator models (reproduced with a FIDO U2F Security Key firmware 4.1.8).
The error is as follows: if certain key handles unknown to the authenticator exist in the allowed credentials set, the authenticator fails the assertion with an "internal error". This PR changes assertions in this specific scenario (U2F key, >1 allowed credential) to run sequentially through each key handle looking for a known credential to use.
#44912
Changelog: Fixes a rare "internal error" on older U2F authenticators when using tsh