fix regression that denied access to launch some Apps#45024
Merged
capnspacehook merged 3 commits intomasterfrom Aug 6, 2024
Merged
fix regression that denied access to launch some Apps#45024capnspacehook merged 3 commits intomasterfrom
capnspacehook merged 3 commits intomasterfrom
Conversation
capnspacehook
force-pushed
the
capnspacehook/fix-app-access-regression
branch
2 times, most recently
from
08455ce to
fea2fa1
Compare
capnspacehook
requested review from
GavinFrazar,
kimlisa,
r0mant and
zmb3
and removed request for
ravicious and
rudream
Contributor
Author
|
Yep, tested with AWS console app and multiple variations of normal apps as well |
zmb3
reviewed
Aug 5, 2024
zmb3
reviewed
Aug 5, 2024
kimlisa
reviewed
Aug 5, 2024
capnspacehook
force-pushed
the
capnspacehook/fix-app-access-regression
branch
2 times, most recently
from
0c64ad9 to
1de5161
Compare
kimlisa
reviewed
Aug 6, 2024
kimlisa
approved these changes
Aug 6, 2024
Contributor
kimlisa
left a comment
kimlisa
left a comment
There was a problem hiding this comment.
@capnspacehook can you review my changes here 08e431b, to make sure i didn't mess up your original logic (i just pulled out common error and wrapped a try catch block)
public-teleport-github-review-bot
Bot
removed the request for review
from GavinFrazar
capnspacehook
force-pushed
the
capnspacehook/fix-app-access-regression
branch
from
615a0fa to
4c2b065
Compare
capnspacehook
force-pushed
the
capnspacehook/fix-app-access-regression
branch
from
4c2b065 to
92492bd
Compare
|
@capnspacehook See the table below for backport results.
|
This was referenced Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44553.
changelog: fix regression that denied access to launch some Apps